fix: do not mutate read-only files #1155
Conversation
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder regarding this pull request. Please let me know if there are any further updates needed. |
|
Hey sorry about the delay. The line endings mutating was added here, #436 to fix issues with Windows. This PR looks good though. Could you please just fix the lining/tests and we can get it merged :) |
iloveitaly
force-pushed
the
dont-mutate-read-only-files
branch
from
ba25d93
to
6b96215
Compare
|
Can you help me with the windows build? I'm a rust beginner and have no idea what the idiomatic way of handling this sort of thing in rust is. |
|
Of course! You should be able to have a separate Line 154 in 2df97bb |
|
This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days |
|
Friendly reminder that this pull request may be closed soon if there is no further activity. Let me know if you need any assistance. |
|
I've updated the |
Right now, if you attempt to build a project that contains read-only files it will fail with a simple permission error. This makes it impossible for the user
to understand what file is causing issues.
The simple fix used here simply does not mutate the line endings on files which cannot be written.
I'm not sure why the line endings are mutated on files or why the entire project directory is copied. I imagine I'm missing something obvious that could cause other downstream impacts,
so I'm opening this PR as the start of a discussion.
This PR:
fixes #1071
related #700
TODO